Skip to content

[pull] main from TryGhost:main#1094

Merged
pull[bot] merged 3 commits intocode:mainfrom
TryGhost:main
Apr 24, 2026
Merged

[pull] main from TryGhost:main#1094
pull[bot] merged 3 commits intocode:mainfrom
TryGhost:main

Conversation

@pull
Copy link
Copy Markdown

@pull pull Bot commented Apr 24, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

9larsons and others added 3 commits April 24, 2026 16:31
… PRs (#27545)

ref https://linear.app/ghost/issue/PLA-33/

Second of the devcontainer series (stacks on top of #27544). Turns the "Reopen in Container → run three commands" flow into "Reopen in Container → done" by shipping the auto-start task with the repo, and recommends the Dev Containers extension on host so newcomers get prompted to install it.

Also trims CI for dev-tooling-only PRs: the only things running on this PR (and #27544) should now be Setup and anything with no path filter.
…27547)

ref https://linear.app/ghost/issue/PLA-33/

Follow-up to #27544 and #27545. The auto-start flow shipped in #27545 used a `runOn: "folderOpen"` task in `.vscode/tasks.json`, which fires on **host** VS Code too — before the user clicks "Reopen in Container". On a fresh clone the host has no `node_modules`, so the task crashes with `sh: nodemon: command not found` + `Command "nx" not found`, greeting first-time contributors with a wall of red errors.

This PR moves auto-start into the **devcontainer lifecycle** so it only fires inside the container, and also fixes a second fresh-clone failure mode discovered while testing: Ghost's backend crashes importing `@tryghost/parse-email-address` because its `build/` output doesn't exist yet.
The `/mail/u/<email>/` path only resolves when that exact address is
already signed in at the `<X>` account slot, so Workspace accounts and
signed-out users hit a 404 before the `#search` fragment could run.
Switched to `/mail/u/0/?authuser=<email>`, which uses Gmail's own
account resolver and falls through to the sign-in flow instead of
erroring.
@pull pull Bot locked and limited conversation to collaborators Apr 24, 2026
@pull pull Bot added the ⤵️ pull label Apr 24, 2026
@pull pull Bot merged commit cbb3b7e into code:main Apr 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants